build-gnu.sh: Use MULTICALL=y for faster build time#9236
build-gnu.sh: Use MULTICALL=y for faster build time#9236oech3 wants to merge 16 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
a5223c5 to
58f0afe
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
We previously saw multicall binary specific issues. But it was symlink specific. This PR is using hardlinks. Why broken? |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #9236 will not alter performanceComparing Summary
Footnotes
|
a6d41b5 to
5344509
Compare
|
GNU testsuite comparison: |
|
Copies (instead of hardlinks) does not work too. Strange... |
|
Copied binaries inherit wrong SELinux contexts. Try relabeling after copying: chcon -t bin_t "${UU_BUILD_DIR}/${binary}" 2>/dev/null || true |
|
Are labels not provided by test tools after copying automatically? |
|
No. When using cp --remove-destination, the new file gets the destination directory's default context, not the original file's context. SELinux doesn't auto-relabel copied binaries. Fix: Add restorecon after copying to restore proper contexts based on system policy rules. This will give each binary (install, id, mkdir, etc.) the correct bin_t context that SELinux policies expect. ref: |
|
GNU testsuite comparison: |
|
Would you push suggestion button? Thankyou. |
Co-authored-by: Cả thế giới là Rust <90588855+naoNao89@users.noreply.github.com>
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
Hmm.. still failing. Saving 10 min+ is large advantage. I don't want giveup. |
|
GNU testsuite comparison: |
- name: Build with SELinux support
run: |
SELINUX_ENABLED=1 util/build-gnu.sh |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
gud luck :)))) |
|
@Ecordonnier Can you fix this? |
d96ed99 to
aabbcbe
Compare
49cb87b to
61a1874
Compare
|
Sad that failed to omit 10 min+. But I can't. |
Sorry, due to a technical issue I was not receiving notifications per email. This has been fixed now. What do you want me to fix? |
|
What do you want me to fix?
Copies of multicall binary did not work on GNU test suite if SELINUX_ENABLED=1.
Is this related with AppArmor things too?
|
I don't know. I haven't worked on this part. |
|
OK. Thankyou. |
No description provided.